-
Notifications
You must be signed in to change notification settings - Fork 2.7k
(Closed) #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SoldierSacha
wants to merge
138
commits into
modelcontextprotocol:main
from
sacha-development-stuff:claude/fix-oauth2-type-errors-011CUn6gBiipfcgGJxAktRaV
Closed
(Closed) #1568
SoldierSacha
wants to merge
138
commits into
modelcontextprotocol:main
from
sacha-development-stuff:claude/fix-oauth2-type-errors-011CUn6gBiipfcgGJxAktRaV
+1,146
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-oauth-client-credentials Add OAuth client credentials grant
…mplement-client-credentials-support Fix auth registration for client credentials
…mentation-of-client-credentials-flow Refactor auth helper methods
Fix failing tests and pyright
…eerror-in-pytest-test-case Fix OAuth tests using async fixtures
Fix resumption token update logic
Add OAuth token exchange support
…change-implementation-for-test-failures Fix token exchange metadata tests
Reported-by: sachabaniassad
Fix pyright case issues in tests and example
…-test-for-client-registration Allow additional grant types during client registration
…ge-conflicts-in-sdk-fork Resolve OAuth auth flow merge conflicts
…ionreseterror-in-stdio_client-test Handle closed stdin in stdio client
# Conflicts: # src/mcp/client/auth/oauth2.py # src/mcp/shared/auth.py # tests/client/test_auth.py # tests/issues/test_88_random_error.py # tests/shared/test_streamable_http.py
…hub-merge-conflicts-for-oauth-support Resolve upstream merge conflicts while preserving OAuth extensions
Add explicit None checks for client_id fields before passing to functions that expect str. This fixes type errors where str | None was being passed to parameters that require str. Changes: - simple_auth_provider.py: Add client_id validation in exchange_client_credentials and exchange_token - oauth2.py: Add client_id check at start of _apply_client_auth method - test_auth_integration.py: Add assertions for client_id not being None in test mock methods This ensures proper type safety and prevents potential None dereference errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context